Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 231663005: Put patches to refs/patches/<username>/<patchname> (Closed)

Created:
6 years, 8 months ago by nodir
Modified:
6 years, 8 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Put patches to refs/patches/<user>/<name> When using Git, trychange.py used to put patches to refs/patches/<name> refs, where <name> is a name of a patch. Now the using the username as a part of the path. This way we have better control over permissions per user basis R=agable@chromium.org, iannucci@chromium.org TEST=Sent a change to quickoffice try server. Master and slave do not need to be modified because the ref file in master branch points to the correct branch name Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263432

Patch Set 1 #

Total comments: 4

Patch Set 2 : KISS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M trychange.py View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nodir
PTAL
6 years, 8 months ago (2014-04-09 22:44:10 UTC) #1
agable
https://codereview.chromium.org/231663005/diff/1/trychange.py File trychange.py (right): https://codereview.chromium.org/231663005/diff/1/trychange.py#newcode514 trychange.py:514: def _PrepareDescriptionAndPatchFiles(description, options, use_username=True): Why add this complexity? The ...
6 years, 8 months ago (2014-04-11 20:53:10 UTC) #2
nodir
Done! https://codereview.chromium.org/231663005/diff/1/trychange.py File trychange.py (right): https://codereview.chromium.org/231663005/diff/1/trychange.py#newcode514 trychange.py:514: def _PrepareDescriptionAndPatchFiles(description, options, use_username=True): Good point https://codereview.chromium.org/231663005/diff/1/trychange.py#newcode648 trychange.py:648: ...
6 years, 8 months ago (2014-04-11 23:49:59 UTC) #3
agable
LGTM
6 years, 8 months ago (2014-04-12 00:56:38 UTC) #4
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 8 months ago (2014-04-12 00:59:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/231663005/20001
6 years, 8 months ago (2014-04-12 00:59:55 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 01:01:35 UTC) #7
Message was sent while issue was closed.
Change committed as 263432

Powered by Google App Engine
This is Rietveld 408576698