Issue 231663002: too aggressive on seccomp cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231663002: too aggressive on seccomp cleanup (Closed)

Created:
6 years, 8 months ago by jcgregorio

Modified:
6 years, 8 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

I got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have the linux/seccomp.h header. Also forgot one last place that referenced syscall_reporter. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14119

Patch Set 1 #

Patch Set 2 : fix whitespace #

Patch Set 3 : remove exe #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	experimental/webtry/seccomp_bpf.h	View	1	1 chunk	+21 lines, -1 line	0 comments	Download
	M	experimental/webtry/webtry.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/231663002/20002

6 years, 8 months ago (2014-04-09 20:15:15 UTC) #4

Message was sent while issue was closed.

Change committed as 14119

Expand Messages | Collapse Messages