Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2316623004: Merged: Disallow tail calls from async functions and generators (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: Disallow tail calls from async functions and generators Revision: 5af4cd984067f4e316aea04ef381a00724b5a8bf BUG=chromium:639270, v8:5301 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=adamk@chromium.org, adamk Committed: https://chromium.googlesource.com/v8/v8/+/fcb0004e2375cc7a449b9936737b6d6c18bc8f30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser-base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/es8/syntactic-tail-call-parsing.js View 4 chunks +8 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-639270.js View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-06 22:19:18 UTC) #1
Dan Ehrenberg
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 3 months ago (2016-09-06 22:19:19 UTC) #2
Dan Ehrenberg
Tested simple but non-automatic merge locally
4 years, 3 months ago (2016-09-06 22:22:43 UTC) #3
adamk
lgtm
4 years, 3 months ago (2016-09-06 22:27:04 UTC) #4
Dan Ehrenberg
4 years, 3 months ago (2016-09-06 22:29:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcb0004e2375cc7a449b9936737b6d6c18bc8f30.

Powered by Google App Engine
This is Rietveld 408576698