third_party/WebKit/Source/core/loader/PingLoader.cpp - Issue 2316573002: PlzNavigate: Support ResourceTiming API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2316573002: PlzNavigate: Support ResourceTiming API (Closed)

Patch Set: Nit + rebase + build fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/frame_messages.h ('K') | « third_party/WebKit/Source/core/fetch/ResourceLoader.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/PingLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp

index eda58be918b50d7320748d833e0cc1b2af001d46..0808f92c92cf7e468155ecd349b9fe9d5cc222f4 100644

--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp

@@ -213,7 +213,7 @@ private:

void dispose();

// WebURLLoaderClient

- void willFollowRedirect(WebURLLoader*, WebURLRequest&, const WebURLResponse&, int64_t encodedDataLength) override;

+ void willFollowRedirect(WebURLLoader*, WebURLRequest&, const WebURLResponse&) override;

void didReceiveResponse(WebURLLoader*, const WebURLResponse&) final;

void didReceiveData(WebURLLoader*, const char*, int, int, int) final;

void didFinishLoading(WebURLLoader*, double, int64_t) final;

@@ -290,7 +290,7 @@ void PingLoaderImpl::dispose()

m_keepAlive.clear();

}

-void PingLoaderImpl::willFollowRedirect(WebURLLoader*, WebURLRequest& passedNewRequest, const WebURLResponse& passedRedirectResponse, int64_t encodedDataLength)

+void PingLoaderImpl::willFollowRedirect(WebURLLoader*, WebURLRequest& passedNewRequest, const WebURLResponse& passedRedirectResponse)

{

if (!m_isBeacon)

return;