Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: runtime/vm/snapshot.cc

Issue 2316513005: Separate size stats for rodata and instructions. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc
index d6891e27c9ebdc4527c9228ebe39f31db6a8dd2e..0062dacd54416bf28618fe500a12d7036128c274 100644
--- a/runtime/vm/snapshot.cc
+++ b/runtime/vm/snapshot.cc
@@ -733,10 +733,10 @@ void AssemblyInstructionsWriter::Write() {
// This head also provides the gap to make the instructions snapshot
// look like a HeapPage.
intptr_t instructions_length = next_offset_;
- WriteWordLiteral(instructions_length);
+ WriteWordLiteralText(instructions_length);
intptr_t header_words = InstructionsSnapshot::kHeaderSize / sizeof(uword);
for (intptr_t i = 1; i < header_words; i++) {
- WriteWordLiteral(0);
+ WriteWordLiteralText(0);
}
Object& owner = Object::Handle(zone);
@@ -763,13 +763,13 @@ void AssemblyInstructionsWriter::Write() {
marked_tags = RawObject::VMHeapObjectTag::update(true, marked_tags);
marked_tags = RawObject::MarkBit::update(true, marked_tags);
- WriteWordLiteral(marked_tags);
+ WriteWordLiteralText(marked_tags);
beginning += sizeof(uword);
for (uword* cursor = reinterpret_cast<uword*>(beginning);
cursor < reinterpret_cast<uword*>(entry);
cursor++) {
- WriteWordLiteral(*cursor);
+ WriteWordLiteralText(*cursor);
}
}
@@ -808,7 +808,7 @@ void AssemblyInstructionsWriter::Write() {
for (uword* cursor = reinterpret_cast<uword*>(entry);
cursor < reinterpret_cast<uword*>(end);
cursor++) {
- WriteWordLiteral(*cursor);
+ WriteWordLiteralText(*cursor);
}
}
}
@@ -824,7 +824,7 @@ void AssemblyInstructionsWriter::Write() {
// Start snapshot at page boundary.
assembly_stream_.Print(".balign %" Pd ", 0\n", VirtualMemory::PageSize());
assembly_stream_.Print("_kDataSnapshot:\n");
- WriteWordLiteral(next_object_offset_); // Data length.
+ WriteWordLiteralData(next_object_offset_); // Data length.
COMPILE_ASSERT(OS::kMaxPreferredCodeAlignment >= kObjectAlignment);
assembly_stream_.Print(".balign %" Pd ", 0\n",
OS::kMaxPreferredCodeAlignment);
@@ -841,12 +841,12 @@ void AssemblyInstructionsWriter::Write() {
uword marked_tags = obj.raw()->ptr()->tags_;
marked_tags = RawObject::VMHeapObjectTag::update(true, marked_tags);
marked_tags = RawObject::MarkBit::update(true, marked_tags);
- WriteWordLiteral(marked_tags);
+ WriteWordLiteralData(marked_tags);
start += sizeof(uword);
for (uword* cursor = reinterpret_cast<uword*>(start);
cursor < reinterpret_cast<uword*>(end);
cursor++) {
- WriteWordLiteral(*cursor);
+ WriteWordLiteralData(*cursor);
}
}
}
« no previous file with comments | « runtime/vm/snapshot.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698