[regexp] Install all getters and setters as DONT_ENUM

[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=v8:5339
Committed: https://crrev.com/71668bbb5c7d0e65b75fca572cd9e90fe2db2284
Cr-Commit-Position: refs/heads/master@{#39191}

[jgruber, 2016-09-06 07:14:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 07:14:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-09-06 07:19:16]

jgruber@chromium.org changed reviewers:
+ bmeurer@chromium.org

[jgruber, 2016-09-06 07:19:17]

This CL should fix the layout test failures we've been getting due to:

-PASS Object.getOwnPropertyDescriptor(RegExp, '$_').configurable is true
+FAIL Object.getOwnPropertyDescriptor(RegExp, '$_').configurable should be true.
Was false.

At some point we should revisit this and set more restrictive attributes.

[Benedikt Meurer, 2016-09-06 07:19:51]

lgtm

[jgruber, 2016-09-06 07:20:05]

On 2016/09/06 07:19:17, jgruber wrote:
> This CL should fix the layout test failures we've been getting due to:
> 
> -PASS Object.getOwnPropertyDescriptor(RegExp, '$_').configurable is true
> +FAIL Object.getOwnPropertyDescriptor(RegExp, '$_').configurable should be
true.
> Was false.
> 
> At some point we should revisit this and set more restrictive attributes.

And here's an example of the failures: 

https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/6726

[Michael Achenbach, 2016-09-06 07:30:33]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-09-06 07:30:34]

Thanks! Can I switch dry run to commit?

[Michael Achenbach, 2016-09-06 07:30:52]

Maybe reference the other BUG?

[jgruber, 2016-09-06 07:34:12]

Description was changed from

==========
[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=
==========

to

==========
[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=v8:5339
==========

[Michael Achenbach, 2016-09-06 07:34:46]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-09-06 07:34:51]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-09-06 07:34:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 07:36:48]

Description was changed from

==========
[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=v8:5339
==========

to

==========
[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=v8:5339
==========

[commit-bot: I haz the power, 2016-09-06 07:36:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-06 07:37:19]

Description was changed from

==========
[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=v8:5339
==========

to

==========
[regexp] Install all getters and setters as DONT_ENUM

Prior to 69debbb50c0ad62aba37c410c0aa917211805839, InstallGetterSetter
was bugged and ignored all passed attributes, installing as DONT_ENUM
instead. This commit makes sure we match old behavior now that that bug
is fixed.

BUG=v8:5339

Committed: https://crrev.com/71668bbb5c7d0e65b75fca572cd9e90fe2db2284
Cr-Commit-Position: refs/heads/master@{#39191}
==========

[commit-bot: I haz the power, 2016-09-06 07:37:20]

Patchset 1 (id:??) landed as
https://crrev.com/71668bbb5c7d0e65b75fca572cd9e90fe2db2284
Cr-Commit-Position: refs/heads/master@{#39191}