Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2316513002: [heap] Cleanup heap.h (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup heap.h - Move implemnetation details into -inl.h or .cc file - Inline NewSpace::Contains manually R=ulan@chromium.org Committed: https://crrev.com/985afadfcc843eac280a055dda85b9e663760ac6 Cr-Commit-Position: refs/heads/master@{#39196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -67 lines) Patch
M src/heap/heap.h View 7 chunks +14 lines, -64 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +71 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Lippautz
4 years, 3 months ago (2016-09-05 17:52:51 UTC) #6
ulan
lgtm
4 years, 3 months ago (2016-09-06 08:36:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316513002/1
4 years, 3 months ago (2016-09-06 08:59:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 09:02:13 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 09:02:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/985afadfcc843eac280a055dda85b9e663760ac6
Cr-Commit-Position: refs/heads/master@{#39196}

Powered by Google App Engine
This is Rietveld 408576698