Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2316503004: KeyedLookupCache and DescriptorLookupCache -> lookup-cache{-inl.h,.cc,.h} (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

KeyedLookupCache and DescriptorLookupCache -> lookup-cache{-inl.h,.cc,.h} R=verwaest@chromium.org BUG= Committed: https://crrev.com/1ea41a466c2666e0b709efd320198f2f626c877b Cr-Commit-Position: refs/heads/master@{#39212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -214 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M src/lookup.h View 1 chunk +0 lines, -101 lines 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -71 lines 0 comments Download
A src/lookup-cache.h View 1 chunk +117 lines, -0 lines 0 comments Download
A src/lookup-cache.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A + src/lookup-cache-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
D src/lookup-inl.h View 1 chunk +0 lines, -38 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
4 years, 3 months ago (2016-09-06 14:09:56 UTC) #1
Toon Verwaest
lgtm
4 years, 3 months ago (2016-09-06 14:22:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316503004/1
4 years, 3 months ago (2016-09-06 14:26:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 14:57:03 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 14:58:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ea41a466c2666e0b709efd320198f2f626c877b
Cr-Commit-Position: refs/heads/master@{#39212}

Powered by Google App Engine
This is Rietveld 408576698