Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2316503003: Register ntp_tiles preferences on iOS. (Closed)

Created:
4 years, 3 months ago by sfiera
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register ntp_tiles preferences on iOS. BUG=631990 Committed: https://crrev.com/c4bcec99b698de23533d697f20a06d5acb5722fd Cr-Commit-Position: refs/heads/master@{#416631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sfiera
Please see also: https://screenshot.googleplex.com/MCsOB6ASrO3.png https://chromereviews.googleplex.com/501017013/ That is not ready for review yet, but this (trivial) ...
4 years, 3 months ago (2016-09-06 13:05:24 UTC) #2
noyau (Ping after 24h)
lgtm
4 years, 3 months ago (2016-09-06 14:02:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316503003/1
4 years, 3 months ago (2016-09-06 15:19:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 15:52:31 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 15:54:34 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c4bcec99b698de23533d697f20a06d5acb5722fd
Cr-Commit-Position: refs/heads/master@{#416631}

Powered by Google App Engine
This is Rietveld 408576698