Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: components/offline_pages/background/request_picker.cc

Issue 2316493006: Remove obsolete TODO comments (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_picker.cc
diff --git a/components/offline_pages/background/request_picker.cc b/components/offline_pages/background/request_picker.cc
index 02515425d37f7e198169698437b5c60e1342a7aa..e7f770c69f52ed50e31eeed72f700a1523bcea55 100644
--- a/components/offline_pages/background/request_picker.cc
+++ b/components/offline_pages/background/request_picker.cc
@@ -127,15 +127,11 @@ bool RequestPicker::RequestConditionsSatisfied(const SavePageRequest& request) {
// If we have already started this page the max number of times, it is not
// eligible to try again.
- // TODO(petewil): We should have code to remove the page from the
- // queue after the last retry.
if (request.started_attempt_count() >= policy_->GetMaxStartedTries())
return false;
// If we have already completed trying this page the max number of times, it
// is not eligible to try again.
- // TODO(petewil): We should have code to remove the page from the
- // queue after the last retry.
if (request.completed_attempt_count() >= policy_->GetMaxCompletedTries())
return false;
@@ -144,7 +140,6 @@ bool RequestPicker::RequestConditionsSatisfied(const SavePageRequest& request) {
return false;
// If the request is expired, do not consider it.
- // TODO(petewil): We need to remove this from the queue.
base::TimeDelta requestAge = base::Time::Now() - request.creation_time();
if (requestAge >
base::TimeDelta::FromSeconds(
« no previous file with comments | « components/offline_pages/background/request_coordinator.h ('k') | components/offline_pages/background/request_queue_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698