Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 2316493005: Remove calls to deprecated MessageLoop methods in blimp. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in blimp. This CL (hopefully) removes all calls to these methods in blimp: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=dtrainor@chromium.org Committed: https://crrev.com/8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3 Cr-Commit-Position: refs/heads/master@{#416748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M blimp/client/core/compositor/delegated_output_surface_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 20:52:56 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 3 months ago (2016-09-06 22:41:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316493005/1
4 years, 3 months ago (2016-09-06 22:56:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 23:00:59 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:03:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3
Cr-Commit-Position: refs/heads/master@{#416748}

Powered by Google App Engine
This is Rietveld 408576698