Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2316483002: Adjusted grammar in spec to handle nullability token `?`.

Created:
4 years, 3 months ago by eernst
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, floitsch, Leaf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjusted grammar in spec to handle nullability token `?`. As a followup on discussions in dart-lang-evolution issue 59, here is a proposal for grammar updates. It includes new non-terminals `classDenotation` and `classDenotationList` (which are terms denoting a class or a list of classes) and uses them in the locations where the nullability token `?` is not intended to be supported. Moreover, the non-terminal `type` is adjusted to allow a final `?`.

Patch Set 1 #

Patch Set 2 : Added two questionmarks that I forgot at first. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M docs/language/dartLangSpec.tex View 1 10 chunks +25 lines, -13 lines 4 comments Download

Messages

Total messages: 6 (2 generated)
eernst
This CL adjusts the spec according to the discussions about the grammar rules for the ...
4 years, 3 months ago (2016-09-05 15:05:13 UTC) #2
Bob Nystrom
LGTM! Good catch on splitting up type. I didn't consider how it was used in ...
4 years, 3 months ago (2016-09-06 19:29:35 UTC) #4
Lasse Reichstein Nielsen
LGTM w/ comments (*if* we are planning to land this now!) https://codereview.chromium.org/2316483002/diff/20001/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): ...
3 years, 6 months ago (2017-05-30 10:52:30 UTC) #5
Bob Nystrom
3 years, 6 months ago (2017-06-01 23:12:25 UTC) #6
On 2017/05/30 10:52:30, Lasse Reichstein Nielsen wrote:
> LGTM w/ comments (*if* we are planning to land this now!)

I don't think we are, though it's nice to have it waiting in the wings.

– bob

Powered by Google App Engine
This is Rietveld 408576698