Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2316453002: [fullcodegen] Introduce single bottleneck for calling KeyedStoreIC. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Introduce single bottleneck for calling KeyedStoreIC. Committed: https://crrev.com/9b53e7cbdf9a9a3b48474c583beee582d05cf84a Cr-Commit-Position: refs/heads/master@{#39178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -108 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-05 14:29:36 UTC) #5
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-05 14:42:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316453002/20001
4 years, 3 months ago (2016-09-05 14:44:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-05 14:53:55 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 14:54:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b53e7cbdf9a9a3b48474c583beee582d05cf84a
Cr-Commit-Position: refs/heads/master@{#39178}

Powered by Google App Engine
This is Rietveld 408576698