src/debug/arm/debug-arm.cc - Issue 2316443002: Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/debug/arm/debug-arm.cc

Issue 2316443002: Include only stuff you need, part 8: Fix debug.h -> liveedit.h. (Closed)

Patch Set: ports Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2012 the V8 project authors. All rights reserved.	1 // Copyright 2012 the V8 project authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #if V8_TARGET_ARCH_ARM	5 #if V8_TARGET_ARCH_ARM

6	6

	7 #include "src/debug/debug.h"
	Michael Starzinger 2016/09/06 08:05:38 nit: Can we add an empty newline after the first i nit: Can we add an empty newline after the first include, to make it visually obvious that it is the very first one on purpose. WDYT? marja 2016/09/06 08:24:07 Done. Show quoted text On 2016/09/06 08:05:38, Michael Starzinger wrote: > nit: Can we add an empty newline after the first include, to make it visually > obvious that it is the very first one on purpose. WDYT? Done.
7 #include "src/codegen.h"	8 #include "src/codegen.h"

8 #include "src/debug/debug.h"	9 #include "src/debug/liveedit.h"

9	10

10 namespace v8 {	11 namespace v8 {

11 namespace internal {	12 namespace internal {

12	13

13 #define __ ACCESS_MASM(masm)	14 #define __ ACCESS_MASM(masm)

14	15

15	16

16 void EmitDebugBreakSlot(MacroAssembler* masm) {	17 void EmitDebugBreakSlot(MacroAssembler* masm) {

17 Label check_size;	18 Label check_size;

18 __ bind(&check_size);	19 __ bind(&check_size);

(...skipping 136 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
155	156

156	157

157 const bool LiveEdit::kFrameDropperSupported = true;	158 const bool LiveEdit::kFrameDropperSupported = true;

158	159

159 #undef __	160 #undef __

160	161

161 } // namespace internal	162 } // namespace internal

162 } // namespace v8	163 } // namespace v8

163	164

164 #endif // V8_TARGET_ARCH_ARM	165 #endif // V8_TARGET_ARCH_ARM

OLD	NEW

« src/compiler/js-generic-lowering.cc ('K') | « src/crankshaft/hydrogen-instructions.h ('k') | src/debug/arm64/debug-arm64.cc » ('j') | src/debug/live-edit-frame-drop-mode.h » ('J')