Issue 231643005: ozone: Remove the libevent message-pump.

Issue 231643005: ozone: Remove the libevent message-pump. (Closed)

Created:
6 years, 8 months ago by sadrul

Modified:
6 years, 8 months ago

Reviewers:
rjkroege, darin (slow to review), sky

CC:
chromium-reviews, rjkroege, kalyank, erikwright+watch_chromium.org, ozone-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ozone: Remove the libevent message-pump. The ozone message-pump is no longer needed. So remove that, and use the default message-pump based on libevent instead. Also, add a convenience method for adding a watcher on a file-descriptor to the message-pump from the message-loop. BUG=354062 R=rjkroege@chromium.org, sky@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263022

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -139 lines)			Patch
M	base/BUILD.gn	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	base/base.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/message_loop/message_loop.h	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	base/message_loop/message_loop.cc	View		3 chunks	+20 lines, -1 line	0 comments	Download
D	base/message_loop/message_pump_ozone.h	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	base/message_loop/message_pump_ozone.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	ui/events/ozone/evdev/device_manager_udev.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ui/events/ozone/evdev/key_event_converter_evdev.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/events/ozone/evdev/key_event_converter_evdev.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/events/ozone/evdev/touch_event_converter_evdev.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/events/ozone/evdev/touch_event_converter_evdev.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/events/ozone/event_factory_ozone.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

sadrul

+darin@ for base/ owners. By the powers vested in sky@, I am TBR'ing the base/ ...

6 years, 8 months ago (2014-04-10 16:07:56 UTC) #4

sadrul

Committed patchset #2 manually as r263022 (presubmit successful).

6 years, 8 months ago (2014-04-10 17:19:51 UTC) #5

Message was sent while issue was closed.

LGTM (loving all of these patches!)