Added labels under the windows in OverviewMode displaying their current name.

ash/wm/overview/window_selector_item.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
 #define ASH_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
 
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
 #include "ui/gfx/rect.h"
+#include "ui/views/widget/widget.h"

[tdanderson, 2014/04/10 22:37:12]

You can forward-declare the Widget class here instead of #including it. See
http://www.chromium.org/developers/coding-style/cpp-dos-and-donts.

[Nina, 2014/04/14 16:24:04]

Done.

 
 namespace aura {
 class Window;
 }
 
 namespace ash {
 
 // This class represents an item in overview mode. An item can have one or more
 // windows, of which only one can be activated by keyboard (i.e. alt+tab) but
 // any can be selected with a pointer (touch or mouse).
@@ skipping 47 matching lines @@
  protected:
   // Sets the bounds of this selector item to |target_bounds| in |root_window|.
   // If |animate| the windows are animated from their current location.
   virtual void SetItemBounds(aura::Window* root_window,
                              const gfx::Rect& target_bounds,
                              bool animate) = 0;
 
   // Sets the bounds used by the selector item's windows.
   void set_bounds(const gfx::Rect& bounds) { bounds_ = bounds; }
 
+  // Creates a label to display under the window selector item.
+  void UpdateWindowLabels(const gfx::Rect& target_bounds);
+
+  // Returns the label name

[tdanderson, 2014/04/10 22:37:12]

nit: . at end of comment.

[Nina, 2014/04/14 16:24:04]

Done.

+  virtual base::string16 GetLabelName() = 0;
+
  private:
   // The root window this item is being displayed on.
   aura::Window* root_window_;
 
   // The target bounds this selector item is fit within.
   gfx::Rect target_bounds_;
 
   // The actual bounds of the window(s) for this item. The aspect ratio of
   // window(s) are maintained so they may not fill the target_bounds_.
   gfx::Rect bounds_;
 
   // True if running SetItemBounds. This prevents recursive calls resulting from
   // the bounds update when calling ::wm::RecreateWindowLayers to copy
   // a window layer for display on another monitor.
   bool in_bounds_update_;
 
+  // Title to show under the label

[tdanderson, 2014/04/10 22:37:12]

nit: . at end of comment

[Nina, 2014/04/14 16:24:04]

Done.

+  base::string16 item_title_;

[tdanderson, 2014/04/10 22:37:12]

It doesn't look like this member variable is being used anywhere.

[Nina, 2014/04/14 16:24:04]

Done.

+
+  // Label under the window with the tab name.
+  scoped_ptr<views::Widget> window_label_;
+
   DISALLOW_COPY_AND_ASSIGN(WindowSelectorItem);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_