Added labels under the windows in OverviewMode displaying their current name.

ash/wm/overview/window_selector_window.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/window_selector_window.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/overview/scoped_transform_overview_window.h"
 #include "grit/ash_resources.h"
 #include "ui/aura/window.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/transform.h"
 #include "ui/views/controls/button/image_button.h"
+#include "ui/views/controls/label.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 
 namespace {
 
+// Foreground label color. Right now it's white
+static const int kLabelColor = 0xFFFFFFFF;

[flackr, 2014/04/10 15:03:05]

Use SK_ColorWHITE, the type should be SkColor

+
+// Background label color. Right now it's black.
+static const int kLabelBackground = 0x000000;

[flackr, 2014/04/10 15:03:05]

Ditto, use SkColor type and color constant SK_ColorBLACK

+
+views::Widget* CreateWindowLabel(aura::Window* root_window,
+                                 const base::string16 title) {
+  views::Widget* widget = new views::Widget;
+  views::Widget::InitParams params;
+  params.type = views::Widget::InitParams::TYPE_POPUP;
+  params.can_activate = false;
+  params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  params.opacity = views::Widget::InitParams::OPAQUE_WINDOW;
+  params.parent =
+      Shell::GetContainer(root_window, ash::kShellWindowId_OverlayContainer);
+  widget->set_focus_on_creation(false);
+  widget->Init(params);
+  views::Label* label = new views::Label;
+  label->SetEnabledColor(kLabelColor);
+  label->SetBackgroundColor(kLabelBackground);
+  ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
+  label->SetFontList(bundle.GetFontList(ui::ResourceBundle::BoldFont));
+  label->SetText(title);
+  widget->SetContentsView(label);
+  widget->Show();
+  return widget;
+}
+
 views::Widget* CreateCloseWindowButton(aura::Window* root_window,
                                        views::ButtonListener* listener) {
   views::Widget* widget = new views::Widget;
   views::Widget::InitParams params;
   params.type = views::Widget::InitParams::TYPE_POPUP;
   params.can_activate = false;
   params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
   params.parent =
       Shell::GetContainer(root_window, ash::kShellWindowId_OverlayContainer);
@@ skipping 62 matching lines @@
 }
 
 void WindowSelectorWindow::PrepareForOverview() {
   transform_window_.PrepareForOverview();
 }
 
 void WindowSelectorWindow::SetItemBounds(aura::Window* root_window,
                                          const gfx::Rect& target_bounds,
                                          bool animate) {
   gfx::Rect src_rect = transform_window_.GetBoundsInScreen();
-  set_bounds(ScopedTransformOverviewWindow::
-      ShrinkRectToFitPreservingAspectRatio(src_rect, target_bounds));
+  const gfx::Rect window_bounds =
+      ScopedTransformOverviewWindow::
+        ShrinkRectToFitPreservingAspectRatio(src_rect, target_bounds);
+  set_bounds(window_bounds);
   transform_window_.SetTransform(root_window,
       ScopedTransformOverviewWindow::GetTransformForRect(src_rect, bounds()),
       animate);
+  UpdateWindowLabels(window_bounds);
   UpdateCloseButtonBounds();
 }
 
 void WindowSelectorWindow::ButtonPressed(views::Button* sender,
                          const ui::Event& event) {
   views::Widget::GetTopLevelWidgetForNativeView(
       transform_window_.window())->Close();
 }
 
+void WindowSelectorWindow::UpdateWindowLabels(const gfx::Rect& window_bounds) {
+  // TODO Animate the labels with some cute effects

[flackr, 2014/04/10 15:03:05]

TODO(nsatragno). That being said, given everything else in overview is animated
and this feature will be immediately visible I'd prefer it to be done in this
CL. Probably use the same animation as the close button.

+  base::string16 window_title = transform_window_.window()->title();

[flackr, 2014/04/10 15:03:05]

nit, move this to the scope where it's used, i.e. in if.

+  if (!window_label_)
+    window_label_.reset(CreateWindowLabel(GetRootWindow(), window_title));
+  // TODO use constant for box height? Calculate dynamically?

[flackr, 2014/04/10 15:03:05]

Seems like it already uses a constant. That being said, it should likely be
based on the font metrics.
nit: TODO(nsatragno)

+  gfx::Rect label_bounds(window_bounds.x(),
+                         window_bounds.y() + window_bounds.height(),
+                         window_bounds.width(),
+                         40);

[flackr, 2014/04/10 15:03:05]

nit: this height should be defined as a constant.

+  window_label_->GetNativeWindow()->SetBounds(label_bounds);
+}
+
 void WindowSelectorWindow::UpdateCloseButtonBounds() {
   aura::Window* root_window = GetRootWindow();
   gfx::Rect align_bounds(bounds());
   gfx::Transform close_button_transform;
   close_button_transform.Translate(align_bounds.right(), align_bounds.y());
 
   // If the root window has changed, force the close button to be recreated
   // and faded in on the new root window.
   if (close_button_ &&
       close_button_->GetNativeWindow()->GetRootWindow() != root_window) {
@@ skipping 32 matching lines @@
         close_button_->GetNativeWindow()->layer()->GetAnimator());
     settings.SetPreemptionStrategy(
         ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
     settings.SetTransitionDuration(base::TimeDelta::FromMilliseconds(
         ScopedTransformOverviewWindow::kTransitionMilliseconds));
     close_button_->GetNativeWindow()->SetTransform(close_button_transform);
   }
 }
 
 }  // namespace ash