Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2316423004:
[Chromoting] More detail video stub information in it2me_standalone_host (Closed)
Description[Chromoting] More detail video stub information in it2me_standalone_host
This change adds several more video stub related fields in it2me_standalone_host
output.
BUG=
Committed: https://crrev.com/55a11159097de499095065a45798faf8e30db7a4
Cr-Commit-Position: refs/heads/master@{#417720}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Chromoting] More detail video stub information in it2me_standalone_host This change adds several more video stub related fields in it2me_standalone_host output. BUG= ========== to ========== [Chromoting] More detail video stub information in it2me_standalone_host This change adds several more video stub related fields in it2me_standalone_host output. BUG= ==========
zijiehe@chromium.org changed reviewers: + jamiewalch@google.com, joedow@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2316423004/diff/1/remoting/test/fake_connecti... File remoting/test/fake_connection_event_logger.cc (right): https://codereview.chromium.org/2316423004/diff/1/remoting/test/fake_connecti... remoting/test/fake_connection_event_logger.cc:190: << " in " nit, this would be a bit more readble if you moved the associated chunks onto a single line: oc << name_ << ": " << message_size() << " " << unit_ << " in " ...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2316423004/diff/1/remoting/test/fake_connecti... File remoting/test/fake_connection_event_logger.cc (right): https://codereview.chromium.org/2316423004/diff/1/remoting/test/fake_connecti... remoting/test/fake_connection_event_logger.cc:190: << " in " On 2016/09/09 19:23:05, joedow wrote: > nit, this would be a bit more readble if you moved the associated chunks onto a > single line: > oc << name_ << ": " << message_size() << " " << unit_ << " in " ... Done.
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org Link to the patchset: https://codereview.chromium.org/2316423004/#ps20001 (title: "Resolve review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Chromoting] More detail video stub information in it2me_standalone_host This change adds several more video stub related fields in it2me_standalone_host output. BUG= ========== to ========== [Chromoting] More detail video stub information in it2me_standalone_host This change adds several more video stub related fields in it2me_standalone_host output. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Chromoting] More detail video stub information in it2me_standalone_host This change adds several more video stub related fields in it2me_standalone_host output. BUG= ========== to ========== [Chromoting] More detail video stub information in it2me_standalone_host This change adds several more video stub related fields in it2me_standalone_host output. BUG= Committed: https://crrev.com/55a11159097de499095065a45798faf8e30db7a4 Cr-Commit-Position: refs/heads/master@{#417720} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/55a11159097de499095065a45798faf8e30db7a4 Cr-Commit-Position: refs/heads/master@{#417720} |
