| 
    
      
  | 
  
 Chromium Code Reviews| 
         Created: 
          4 years, 3 months ago by Ryan Tseng Modified: 
          
          
          4 years, 3 months ago CC: 
          
          
          
          chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref: 
          
          
          refs/heads/master Project: 
          
          depot_tools Visibility: 
          
          
          
        Public.  | 
      
        
  DescriptionCopy over bot_update_coverage_test.py
BUG=
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/eb20eaeced95cdb07ad711639a8958b8d78cf309
   
  Patch Set 1 #Patch Set 2 : Remove non-existant flag #Patch Set 3 : Remove patch_url #Messages
    Total messages: 25 (17 generated)
     
  
  
 The CQ bit was checked by hinoka@google.com to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Dry run: Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311ff11adcd3b610) 
 hinoka@chromium.org changed reviewers: + agable@chromium.org, hinoka@chromium.org 
 This copies over https://cs.chromium.org/chromium/build/scripts/slave/unittests/bot_update_cov... from build.git, and adds it to depot_tools presubmit (which scans for .*test.py in the /tests/ folder). It's a good starting point to add bot_update tests on top of. 
 lgtm 
 The CQ bit was checked by hinoka@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3120063e0ed89610) 
 The CQ bit was checked by hinoka@google.com to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by hinoka@chromium.org 
 The CQ bit was checked by hinoka@chromium.org 
 The patchset sent to the CQ was uploaded after l-g-t-m from agable@chromium.org Link to the patchset: https://codereview.chromium.org/2316393002/#ps20001 (title: "Remove non-existant flag") 
 The CQ bit was checked by hinoka@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/312018110d38bc10) 
 The CQ bit was checked by hinoka@chromium.org 
 The patchset sent to the CQ was uploaded after l-g-t-m from agable@chromium.org Link to the patchset: https://codereview.chromium.org/2316393002/#ps40001 (title: "Remove patch_url") 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Description was changed from ========== Copy over bot_update_coverage_test.py BUG= ========== to ========== Copy over bot_update_coverage_test.py BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/eb20eaeced95cd... ========== 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/eb20eaeced95cd...  | 
    
