Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2316373006: [cleanup] Remove unused PreParser factory method (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove unused PreParser factory method R=nikolaos@chromium.org Committed: https://crrev.com/39c9158f8e8896f4e2a8533b57b9a743d1067006 Cr-Commit-Position: refs/heads/master@{#39316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/parsing/preparser.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
adamk
4 years, 3 months ago (2016-09-08 23:03:11 UTC) #1
nickie
lgtm
4 years, 3 months ago (2016-09-09 08:09:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316373006/1
4 years, 3 months ago (2016-09-09 17:08:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 17:11:08 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 17:12:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39c9158f8e8896f4e2a8533b57b9a743d1067006
Cr-Commit-Position: refs/heads/master@{#39316}

Powered by Google App Engine
This is Rietveld 408576698