Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2316353002: Revert of 'Adding target to build SwiftShader' (Closed)

Created:
4 years, 3 months ago by sugoi1
Modified:
4 years, 3 months ago
Reviewers:
Nico, lushnikov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 'Adding target to build SwiftShader' Windows buildbot failed, reverting for now. TBR=thakis@chromium.org BUG=630728 NOTREECHECKS=true NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/9773f67d88c0f99b27cc5d2d386870322f692892 Cr-Commit-Position: refs/heads/master@{#417040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316353002/1
4 years, 3 months ago (2016-09-07 21:00:30 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-07 21:00:31 UTC) #4
sugoi1
4 years, 3 months ago (2016-09-07 21:01:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316353002/1
4 years, 3 months ago (2016-09-07 21:02:11 UTC) #9
Nico
lgtm
4 years, 3 months ago (2016-09-07 21:04:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316353002/1
4 years, 3 months ago (2016-09-07 21:10:50 UTC) #14
lushnikov
Thanks for the revert! Added NOTREECHECKS and NOPRESUBMIT to speedup the process
4 years, 3 months ago (2016-09-07 21:21:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316353002/1
4 years, 3 months ago (2016-09-07 21:22:36 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:24:39 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:26:35 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9773f67d88c0f99b27cc5d2d386870322f692892
Cr-Commit-Position: refs/heads/master@{#417040}

Powered by Google App Engine
This is Rietveld 408576698