Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2316343002: Clang Win: turn on -Wno-ignored-pragmas (Closed)

Created:
4 years, 3 months ago by hans
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, agutowski_google.com, Reid Kleckner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hans
Please take a look.
4 years, 3 months ago (2016-09-07 20:48:20 UTC) #2
Nico
lgtm I wonder if this new warning should be under a new -Wignored-pragma-intrin which is ...
4 years, 3 months ago (2016-09-07 21:02:03 UTC) #3
hans
On 2016/09/07 21:02:03, Nico wrote: > I wonder if this new warning should be under ...
4 years, 3 months ago (2016-09-07 21:10:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316343002/1
4 years, 3 months ago (2016-09-07 21:11:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/717f854a7c07dc34dd8cdfd56f5ad1731a2b9a39 Cr-Commit-Position: refs/heads/master@{#417101}
4 years, 3 months ago (2016-09-07 22:40:51 UTC) #8
hans
4 years, 3 months ago (2016-09-07 22:42:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
717f854a7c07dc34dd8cdfd56f5ad1731a2b9a39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698