Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2316303002: Revert of Add GM/slide to simulate Android-style reveal clip (Closed)

Created:
4 years, 3 months ago by robertphillips
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add GM/slide to simulate Android-style reveal clip (patchset #6 id:100001 of https://codereview.chromium.org/2316593003/ ) Reason for revert: Shader compilation failure Original issue's description: > Add GM/slide to simulate Android-style reveal clip > > Hopefully, this will let us play w/ geometric and shader-based solutions. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 > > Committed: https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0 TBR=jvanverth@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/62e9b145a13aa8e119dd7f0bba7ca057b936d639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -315 lines) Patch
D gm/reveal.cpp View 1 chunk +0 lines, -310 lines 0 comments Download
M include/effects/SkGaussianEdgeShader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkGaussianEdgeShader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Add GM/slide to simulate Android-style reveal clip
4 years, 3 months ago (2016-09-07 18:33:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316303002/1
4 years, 3 months ago (2016-09-07 18:33:57 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:34:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/62e9b145a13aa8e119dd7f0bba7ca057b936d639

Powered by Google App Engine
This is Rietveld 408576698