Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 23163011: Expose WorkerNavigator interface to web workers (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Expose WorkerNavigator interface to web workers According to the specification, the WorkerNavigator interface is not a [NoInterfaceObject] and it should be exposed to JavaScript if the JavaScript global environment is a worker environment: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workernavigator BUG=276160 R=haraken@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156395

Patch Set 1 #

Patch Set 2 : No change #

Patch Set 3 : No change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/WorkerNavigator.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-20 10:01:58 UTC) #1
haraken
LGTM. Needs an approval from an API owner. Looks like the diff is broken. You ...
7 years, 4 months ago (2013-08-20 10:25:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-20 11:05:55 UTC) #3
do-not-use
7 years, 4 months ago (2013-08-20 13:38:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r156395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698