Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2316263004: Disable RaceCrossOriginNavigationAndSamePageHistoryNavigation due to flakiness. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index d1a5a7dd3ddac5ec79ab07b253249d1c81e3e410..cb5990daa5b779133e461d72f133aa87c11b3a9d 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -5927,8 +5927,11 @@ class CommitMessageFilter : public BrowserMessageFilter {
// the cross-origin navigation and updates the URL, but not the origin of the
// document. This results in mismatch between the two and causes the renderer
// process to be killed. See https://crbug.com/630103.
-IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
- RaceCrossOriginNavigationAndSamePageHistoryNavigation) {
+// TODO(nasko): Investigate why this test is flaky, likely related to
+// https://crbug.com/638089, and enable once resolved.
+IN_PROC_BROWSER_TEST_F(
+ NavigationControllerBrowserTest,
+ DISABLED_RaceCrossOriginNavigationAndSamePageHistoryNavigation) {
WebContentsImpl* web_contents =
static_cast<WebContentsImpl*>(shell()->web_contents());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698