Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java

Issue 2316263002: Notifications in sensitive contexts now display origin + small icon (Closed)
Patch Set: Notifications in sensitive contexts now display origin + small icon Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
index 474c37ba455f9e8fe566906f3c821c831834e1e2..65cfd24dc56412efc18e38e0d6a6cb819a5cf5a0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
@@ -64,7 +64,9 @@ public class StandardNotificationBuilderTest extends InstrumentationTestCase {
.setDeleteIntent(outContentAndDeleteIntents[1])
.addAction(actionIcon, "button 1", null /* intent */)
.addAction(actionIcon, "button 2", null /* intent */)
- .addSettingsAction(0 /* iconId */, "settings", null /* intent */);
+ .addSettingsAction(0 /* iconId */, "settings", null /* intent */)
+ .setPublicVersion(
+ new StandardNotificationBuilder(context).setTitle("public title").build());
}
@SmallTest
@@ -104,6 +106,13 @@ public class StandardNotificationBuilderTest extends InstrumentationTestCase {
assertEquals("button 1", NotificationTestUtil.getActionTitle(actions[0]));
assertEquals("button 2", NotificationTestUtil.getActionTitle(actions[1]));
assertEquals("settings", NotificationTestUtil.getActionTitle(actions[2]));
+
+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+ // Notification.publicVersion was added in Android L.
+ assertNotNull(notification.publicVersion);
+ assertEquals(
+ "public title", NotificationTestUtil.getExtraTitle(notification.publicVersion));
+ }
}
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698