chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java - Issue 2316263002: Notifications in sensitive contexts now display origin + small icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

Issue 2316263002: Notifications in sensitive contexts now display origin + small icon (Closed)

Patch Set: Notifications in sensitive contexts now display origin + small icon Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

index fec668ac99dca204ddca52b976a67af99de4e52a..fd659acb190318f5766de9f40476a9f46b2ef782 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

@@ -55,6 +55,10 @@ public class StandardNotificationBuilder extends NotificationBuilderBase {

builder.setVibrate(mVibratePattern);

builder.setWhen(mTimestamp);

builder.setOnlyAlertOnce(!mRenotify);

+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {

+ // Notification.Builder.setPublicVersion was added in Android L.

+ builder.setPublicVersion(mPublicVersion);

+ }

return builder.build();

}