chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java - Issue 2316263002: Notifications in sensitive contexts now display origin + small icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2316263002: Notifications in sensitive contexts now display origin + small icon (Closed)

Patch Set: Notifications in sensitive contexts now display origin + small icon Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

index c5dba9603b17b2255cc51453051c99924a5d2683..c1f073ac9eba7108e17a555d1081b3751f0ec8f5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

@@ -161,6 +161,10 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {

if (mSettingsAction != null) {

addActionToBuilder(builder, mSettingsAction);

}

+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {

+ // Notification.Builder.setPublicVersion was added in Android L.

+ builder.setPublicVersion(mPublicVersion);

+ }

Notification notification = builder.build();

notification.bigContentView = bigView;