Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java

Issue 2316263002: Notifications in sensitive contexts now display origin + small icon (Closed)
Patch Set: Notifications in sensitive contexts now display origin + small icon Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
index 474c37ba455f9e8fe566906f3c821c831834e1e2..24c6ac5311ae9dd1668b9294c35e5cd053d3e199 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
@@ -12,17 +12,31 @@ import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.graphics.Color;
import android.os.Build;
-import android.test.InstrumentationTestCase;
import android.test.suitebuilder.annotation.SmallTest;
import android.text.SpannableStringBuilder;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.util.UrlUtilities;
+import org.chromium.chrome.browser.widget.RoundedIconGenerator;
+import org.chromium.content.browser.test.NativeLibraryTestBase;
/**
* Instrumentation unit tests for StandardNotificationBuilder.
+ *
+ * Extends NativeLibraryTestBase so that {@link UrlUtilities#getDomainAndRegistry} can access
+ * native GetDomainAndRegistry, when called by {@link RoundedIconGenerator#getIconTextForUrl} during
+ * notification construction.
*/
-public class StandardNotificationBuilderTest extends InstrumentationTestCase {
+public class StandardNotificationBuilderTest extends NativeLibraryTestBase {
+ @Override
+ public void setUp() throws Exception {
+ super.setUp();
+ // Not initializing the browser process is safe because GetDomainAndRegistry() is
+ // stand-alone.
+ loadNativeLibraryNoBrowserProcess();
+ }
+
private NotificationBuilderBase createAllOptionsBuilder(
PendingIntent[] outContentAndDeleteIntents) {
if (outContentAndDeleteIntents == null || outContentAndDeleteIntents.length != 2)
@@ -104,6 +118,19 @@ public class StandardNotificationBuilderTest extends InstrumentationTestCase {
assertEquals("button 1", NotificationTestUtil.getActionTitle(actions[0]));
assertEquals("button 2", NotificationTestUtil.getActionTitle(actions[1]));
assertEquals("settings", NotificationTestUtil.getActionTitle(actions[2]));
+
+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+ // Notification.publicVersion was added in Android L.
+ assertNotNull(notification.publicVersion);
+ assertEquals(context.getString(R.string.notification_hidden_text),
+ NotificationTestUtil.getExtraText(notification.publicVersion));
+ }
+ if (Build.VERSION.SDK_INT > Build.VERSION_CODES.M) {
+ assertEquals(
+ "origin", NotificationTestUtil.getExtraSubText(notification.publicVersion));
+ } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+ assertEquals("origin", NotificationTestUtil.getExtraTitle(notification.publicVersion));
+ }
}
@SmallTest
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698