Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java

Issue 2316263002: Notifications in sensitive contexts now display origin + small icon (Closed)
Patch Set: Moved public notification creation and icon generation to NotificationBuilderBase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
index e57b40761828b240e34d6dd289ddabae99018a97..d98fbe4c8aac3930e1d51c3ca988e32decb42500 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
@@ -132,10 +132,10 @@ public class RoundedIconGenerator {
* @return The generated icon, or NULL if |url| is empty or the domain cannot be resolved.
*/
@Nullable
- public Bitmap generateIconForUrl(String url, boolean includePrivateRegistries) {
+ public Bitmap generateIconForUrl(CharSequence url, boolean includePrivateRegistries) {
Peter Beverloo 2016/09/12 17:52:02 It looks like this method requires a |url| String
awdf 2016/09/14 12:30:29 Yes, but it will need null checks at the two call-
if (TextUtils.isEmpty(url)) return null;
- String text = getIconTextForUrl(url, includePrivateRegistries);
+ String text = getIconTextForUrl(url.toString(), includePrivateRegistries);
if (TextUtils.isEmpty(text)) return null;
return generateIconForText(text);

Powered by Google App Engine
This is Rietveld 408576698