Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2316233004: Class fields, part 2 (desugaring) (Closed)

Created:
4 years, 3 months ago by bakkot
Modified:
4 years, 2 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Class fields, part 2 (desugaring) This is one part of a WIP implementation of the stage-2 proposal to add fields to classes: https://github.com/tc39/proposal-class-public-fields See design doc: https://docs.google.com/document/d/1WRtNm3ZLNJT1WVr8aq4RJuByYgfuAFAhj20LwTW6JVE/ This adds the desugaring logic to the parser. It isn't usable without the (forthcoming) backend changes. BUG=v8:5367 Committed: https://crrev.com/834aec33918ad645aba3b2662d6ceab056867427 Cr-Commit-Position: refs/heads/master@{#39460}

Patch Set 1 #

Total comments: 25

Patch Set 2 : dan's comments #

Patch Set 3 : proxy support #

Patch Set 4 : rebase #

Patch Set 5 : shorter name #

Patch Set 6 : rebase harder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -5 lines) Patch
M src/ast/ast-value-factory.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 4 5 7 chunks +288 lines, -5 lines 0 comments Download
M src/parsing/parser-base.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 31 (23 generated)
bakkot
PTAL, after the previous patch. This one is where almost all the logic is.
4 years, 3 months ago (2016-09-08 20:32:34 UTC) #2
Dan Ehrenberg
First round of comments https://codereview.chromium.org/2316233004/diff/1/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2316233004/diff/1/src/parsing/parser.cc#newcode154 src/parsing/parser.cc:154: Expression* this_expr) { For desugarings ...
4 years, 3 months ago (2016-09-09 22:54:42 UTC) #4
bakkot
https://codereview.chromium.org/2316233004/diff/1/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2316233004/diff/1/src/parsing/parser.cc#newcode154 src/parsing/parser.cc:154: Expression* this_expr) { On 2016/09/09 at 22:54:42, Dan Ehrenberg ...
4 years, 3 months ago (2016-09-12 19:10:11 UTC) #5
Dan Ehrenberg
lgtm
4 years, 3 months ago (2016-09-13 18:15:18 UTC) #6
Dan Ehrenberg
lgtm Thanks for this fix. With a more descriptive commit message, this patch seems good ...
4 years, 3 months ago (2016-09-13 21:37:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316233004/100001
4 years, 3 months ago (2016-09-16 00:43:25 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-16 00:46:10 UTC) #29
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:47:02 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/834aec33918ad645aba3b2662d6ceab056867427
Cr-Commit-Position: refs/heads/master@{#39460}

Powered by Google App Engine
This is Rietveld 408576698