Move a bunch of ash-only vector icons to ash/.

Move a bunch of ash-only vector icons to ash/.

BUG=626786
Committed: https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8
Cr-Commit-Position: refs/heads/master@{#417402}

[Evan Stade, 2016-09-07 22:17:19]

estade@chromium.org changed reviewers:
+ oshima@chromium.org, tdanderson@chromium.org

[tdanderson, 2016-09-07 22:36:13]

LGTM with a few nits. Thanks for doing this!

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/palette/common_palette_tool.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/palette/common_palette_tool.cc:18: #include
"ui/gfx/vector_icons_public.h"
Is this needed?

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/palette/tools/laser_pointer_mode.h (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/palette/tools/laser_pointer_mode.h:10: #include
"ui/gfx/geometry/point.h"
forward declare rather than #include?

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/labe...
File ash/common/system/tray/label_tray_view.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/labe...
ash/common/system/tray/label_tray_view.cc:24: // Maps a non-MD PNG resource id
to its corresponding MD vector icon id.
nit: "to its corresponding MD vector icon id" -> maybe drop the "id"

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_image_item.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_image_item.cc:25: // Maps a non-MD PNG resource id
to its corresponding MD vector icon id.
same as previous comment

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_notification_view.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_notification_view.cc:25: // Maps a non-MD PNG
resource id to its corresponding MD vector icon id.
same as previous comment

[Evan Stade, 2016-09-07 22:41:52]

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/palette/common_palette_tool.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/palette/common_palette_tool.cc:18: #include
"ui/gfx/vector_icons_public.h"
On 2016/09/07 22:36:13, tdanderson wrote:
> Is this needed?

yes, for CHECK_CIRCLE

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/palette/tools/laser_pointer_mode.h (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/palette/tools/laser_pointer_mode.h:10: #include
"ui/gfx/geometry/point.h"
On 2016/09/07 22:36:13, tdanderson wrote:
> forward declare rather than #include?

not possible for non-pod member

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/labe...
File ash/common/system/tray/label_tray_view.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/labe...
ash/common/system/tray/label_tray_view.cc:24: // Maps a non-MD PNG resource id
to its corresponding MD vector icon id.
On 2016/09/07 22:36:13, tdanderson wrote:
> nit: "to its corresponding MD vector icon id" -> maybe drop the "id"

Done.

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_image_item.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_image_item.cc:25: // Maps a non-MD PNG resource id
to its corresponding MD vector icon id.
On 2016/09/07 22:36:13, tdanderson wrote:
> same as previous comment

Done.

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_notification_view.cc (right):

https://codereview.chromium.org/2316183003/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_notification_view.cc:25: // Maps a non-MD PNG
resource id to its corresponding MD vector icon id.
On 2016/09/07 22:36:13, tdanderson wrote:
> same as previous comment

Done.

[Evan Stade, 2016-09-07 22:41:54]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:42:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:13:51]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-08 14:56:35]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-08 14:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2316183003/#ps20001
(title: "drop the "id". Just "icon". It's cleaner.")

[commit-bot: I haz the power, 2016-09-08 14:56:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 15:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 15:06:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2016-09-08 20:33:30]

lgtm

[Evan Stade, 2016-09-08 21:17:39]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 21:26:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 21:27:55]

Description was changed from

==========
Move a bunch of ash-only vector icons to ash/.

BUG=626786
==========

to

==========
Move a bunch of ash-only vector icons to ash/.

BUG=626786

Committed: https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8
Cr-Commit-Position: refs/heads/master@{#417402}
==========

[commit-bot: I haz the power, 2016-09-08 21:27:56]

Patchset 2 (id:??) landed as
https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8
Cr-Commit-Position: refs/heads/master@{#417402}