Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2316123002:
Switch Canvas2DLayerBridge to new SkColorSpace gamma APIs (Closed)
|
Created:
4 years, 3 months ago by msarett Modified:
4 years, 3 months ago CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitch Canvas2DLayerBridge to new SkColorSpace gamma APIs
This is an incremental step in the clean-up of
SkColorSpace enums. Shouldn't change any behavior.
BUG=
Committed: https://crrev.com/776841afc6dd521a92aa11cf0eeff085dc3024f1
Cr-Commit-Position: refs/heads/master@{#417000}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
Description was changed from ========== Remove uses of deprecated SkColorSpace gammaNamed() BUG= ========== to ========== Remove uses of deprecated SkColorSpace gammaNamed() This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ==========
Description was changed from ========== Remove uses of deprecated SkColorSpace gammaNamed() This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ========== to ========== Switch Canvas2DLayterBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ==========
msarett@google.com changed reviewers: + fmalita@chromium.org, junov@chromium.org
Will require waiting for the Skia roll.
On 2016/09/07 14:16:06, msarett wrote: > Will require waiting for the Skia roll. lgtm
lgtm
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Switch Canvas2DLayterBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ========== to ========== Switch Canvas2DLayerBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Switch Canvas2DLayerBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ========== to ========== Switch Canvas2DLayerBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Switch Canvas2DLayerBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= ========== to ========== Switch Canvas2DLayerBridge to new SkColorSpace gamma APIs This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= Committed: https://crrev.com/776841afc6dd521a92aa11cf0eeff085dc3024f1 Cr-Commit-Position: refs/heads/master@{#417000} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/776841afc6dd521a92aa11cf0eeff085dc3024f1 Cr-Commit-Position: refs/heads/master@{#417000} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
