Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2316083002: [compiler] Stop delegating CompilationInfo::context. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Stop delegating CompilationInfo::context. This implements the CompilationInfo::context explicitly instead of delegating to the underlying ParseInfo. This is in preparation for ParseInfo not having to store the context at all soon. R=jochen@chromium.org Committed: https://crrev.com/8d1ec9b1f562497aec930e0a91b2296b8d8fa9b3 Cr-Commit-Position: refs/heads/master@{#39244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/compilation-info.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compilation-info.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
As soon as we deserialize Scope-chain from the ScopeInfo-chain instead of the Context-chain, we can ...
4 years, 3 months ago (2016-09-07 11:23:42 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-07 11:24:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316083002/1
4 years, 3 months ago (2016-09-07 12:00:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 12:02:56 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 12:03:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d1ec9b1f562497aec930e0a91b2296b8d8fa9b3
Cr-Commit-Position: refs/heads/master@{#39244}

Powered by Google App Engine
This is Rietveld 408576698