Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2316073002: views_examples: use fixed widths for button sticker sheet (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views_examples: use fixed widths for button sticker sheet Having the buttons widen with the window makes them difficult to tell apart. Instead, this change causes the columns to have fixed width and the padding columns to resize. BUG=644546 Committed: https://crrev.com/a92a259a25bb92b18239a9d27d9f21635a6fb61f Cr-Commit-Position: refs/heads/master@{#416943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M ui/views/examples/button_sticker_sheet.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
sky: ptal? :)
4 years, 3 months ago (2016-09-07 11:14:42 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-07 15:13:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316073002/1
4 years, 3 months ago (2016-09-07 15:14:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 15:55:10 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 15:56:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a92a259a25bb92b18239a9d27d9f21635a6fb61f
Cr-Commit-Position: refs/heads/master@{#416943}

Powered by Google App Engine
This is Rietveld 408576698