Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2840)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2316053002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setSelectio… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 306cafeb0070d0079fe460c794ddffa23187b071..a0bd0e00382e0c2f5c5eb6f88f675903c210a626 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1220,6 +1220,11 @@ void WebLocalFrameImpl::moveCaretSelection(const WebPoint& pointInViewport)
bool WebLocalFrameImpl::setEditableSelectionOffsets(int start, int end)
{
TRACE_EVENT0("blink", "WebLocalFrameImpl::setEditableSelectionOffsets");
+
+ // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
return frame()->inputMethodController().setEditableSelectionOffsets(PlainTextRange(start, end));
}

Powered by Google App Engine
This is Rietveld 408576698