Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setSelectio…

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/Editor.h"
@@ skipping 39 matching lines @@
     element->focus();
     return element;
 }
 
 TEST_F(InputMethodControllerTest, BackspaceFromEndOfInput)
 {
     HTMLInputElement* input = toHTMLInputElement(
         insertHTMLElement("<input id='sample'>", "sample"));
 
     input->setValue("fooX");
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("fooX", input->value().utf8().data());
     controller().extendSelectionAndDelete(0, 0);
     EXPECT_STREQ("fooX", input->value().utf8().data());
 
     input->setValue("fooX");
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("fooX", input->value().utf8().data());
     controller().extendSelectionAndDelete(1, 0);
     EXPECT_STREQ("foo", input->value().utf8().data());
 
     input->setValue(String::fromUTF8("foo\xE2\x98\x85")); // U+2605 == "black star"
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("foo\xE2\x98\x85", input->value().utf8().data());
     controller().extendSelectionAndDelete(1, 0);
     EXPECT_STREQ("foo", input->value().utf8().data());
 
     input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86")); // U+1F3C6 == "trophy"
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("foo\xF0\x9F\x8F\x86", input->value().utf8().data());
     controller().extendSelectionAndDelete(1, 0);
     EXPECT_STREQ("foo", input->value().utf8().data());
 
     input->setValue(String::fromUTF8("foo\xE0\xB8\x81\xE0\xB9\x89")); // composed U+0E01 "ka kai" + U+0E49 "mai tho"
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("foo\xE0\xB8\x81\xE0\xB9\x89", input->value().utf8().data());
     controller().extendSelectionAndDelete(1, 0);
     EXPECT_STREQ("foo", input->value().utf8().data());
 
     input->setValue("fooX");
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("fooX", input->value().utf8().data());
     controller().extendSelectionAndDelete(0, 1);
     EXPECT_STREQ("fooX", input->value().utf8().data());
 }
 
 TEST_F(InputMethodControllerTest, SetCompositionFromExistingText)
 {
     Element* div = insertHTMLElement(
         "<div id='sample' contenteditable='true'>hello world</div>", "sample");
@@ skipping 24 matching lines @@
     EXPECT_EQ(0, frame().selection().start().computeOffsetInContainerNode());
     EXPECT_EQ(0, frame().selection().end().computeOffsetInContainerNode());
 }
 
 TEST_F(InputMethodControllerTest, DeleteBySettingEmptyComposition)
 {
     HTMLInputElement* input = toHTMLInputElement(
         insertHTMLElement("<input id='sample'>", "sample"));
 
     input->setValue("foo ");
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("foo ", input->value().utf8().data());
     controller().extendSelectionAndDelete(0, 0);
     EXPECT_STREQ("foo ", input->value().utf8().data());
 
     input->setValue("foo ");
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("foo ", input->value().utf8().data());
     controller().extendSelectionAndDelete(1, 0);
     EXPECT_STREQ("foo", input->value().utf8().data());
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, 3, Color(255, 0, 0), false, 0));
     controller().setCompositionFromExistingText(underlines, 0, 3);
 
     controller().setComposition(String(""), underlines, 0, 3);
@@ skipping 44 matching lines @@
 
     EXPECT_STREQ("foo", input->value().utf8().data());
 }
 
 TEST_F(InputMethodControllerTest, SetCompositionForInputWithDifferentNewCursorPositions)
 {
     HTMLInputElement* input = toHTMLInputElement(
         insertHTMLElement("<input id='sample'>", "sample"));
 
     input->setValue("hello");
+    document().updateStyleAndLayout();
     controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
     EXPECT_STREQ("hello", input->value().utf8().data());
     EXPECT_EQ(2u, controller().getSelectionOffsets().start());
     EXPECT_EQ(2u, controller().getSelectionOffsets().end());
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, 2, Color(255, 0, 0), false, 0));
 
     // The cursor exceeds left boundary.
     // "*heABllo", where * stands for cursor.
@@ skipping 263 matching lines @@
     document().setTitle(emptyString());
     controller().setComposition("ni", underlines, 0, 1);
     EXPECT_STREQ("beforeinput.data:ni;input.data:ni;", document().title().utf8().data());
 
     document().setTitle(emptyString());
     controller().confirmComposition();
     EXPECT_STREQ("beforeinput.data:ni;input.data:ni;", document().title().utf8().data());
 }
 
 } // namespace blink