content/browser/notifications/platform_notification_context_unittest.cc - Issue 2316043002: //content: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/platform_notification_context_unittest.cc

Issue 2316043002: //content: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Just rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database_unittest.cc ('k') | content/browser/quota/mock_quota_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/platform_notification_context_unittest.cc

diff --git a/content/browser/notifications/platform_notification_context_unittest.cc b/content/browser/notifications/platform_notification_context_unittest.cc

index a72fd383cfb639159d04da003aa3519e834aa7fc..52f1e59a8bfdb7db355d97e7fdafc670da805d6d 100644

--- a/content/browser/notifications/platform_notification_context_unittest.cc

+++ b/content/browser/notifications/platform_notification_context_unittest.cc

@@ -396,7 +396,7 @@ TEST_F(PlatformNotificationContextTest, DestroyOnDiskDatabase) {

// Manually construct the PlatformNotificationContextImpl because this test

// requires the database to be created on the filesystem.

scoped_refptr<PlatformNotificationContextImpl> context(

- new PlatformNotificationContextImpl(database_dir.path(),

+ new PlatformNotificationContextImpl(database_dir.GetPath(),

browser_context(), nullptr));

OverrideTaskRunnerForTesting(context.get());

@@ -409,7 +409,7 @@ TEST_F(PlatformNotificationContextTest, DestroyOnDiskDatabase) {

base::RunLoop().RunUntilIdle();

- EXPECT_FALSE(IsDirectoryEmpty(database_dir.path()));

+ EXPECT_FALSE(IsDirectoryEmpty(database_dir.GetPath()));

EXPECT_FALSE(success());

// Blow away the database by faking a Service Worker Context wipe-out.

@@ -418,7 +418,7 @@ TEST_F(PlatformNotificationContextTest, DestroyOnDiskDatabase) {

base::RunLoop().RunUntilIdle();

// The database's directory should be empty at this point.

- EXPECT_TRUE(IsDirectoryEmpty(database_dir.path()));

+ EXPECT_TRUE(IsDirectoryEmpty(database_dir.GetPath()));

}

TEST_F(PlatformNotificationContextTest, ReadAllServiceWorkerDataEmpty) {