//content: Change ScopedTempDir::path() to GetPath()

content/browser/cache_storage/cache_storage_cache_unittest.cc

Index: content/browser/cache_storage/cache_storage_cache_unittest.cc
diff --git a/content/browser/cache_storage/cache_storage_cache_unittest.cc b/content/browser/cache_storage/cache_storage_cache_unittest.cc
index 7c2b0b27704ce732409d9a8c40a5615b17d9b847..1834e8f3d1251a55634699386a90669defd8c979 100644
--- a/content/browser/cache_storage/cache_storage_cache_unittest.cc
+++ b/content/browser/cache_storage/cache_storage_cache_unittest.cc
@@ -331,13 +331,16 @@ class CacheStorageCacheTest : public testing::Test {
     base::RunLoop().RunUntilIdle();
     blob_storage_context_ = blob_storage_context->context();
 
-    if (!MemoryOnly())
+    const bool is_incognito = MemoryOnly();

[vabr (Chromium), 2016/09/09 15:41:46]

Here I forced the test to remember whether it initialised |temp_dir_| rather
than relying on |temp_dir_|'s path to give the information (which would now
DCHECK).

This does not really avoid the issue of writing files to the empty path by
accident. For that, a deeper refactoring of the related production code would be
needed (likely separate implementation of QuotaDatabase for in-memory and
on-disk storage), which seems beyond the scoped of this CL.

[nhiroki, 2016/09/12 01:50:08]

Acknowledged.

+    base::FilePath temp_dir_path;
+    if (!is_incognito) {
       ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+      temp_dir_path = temp_dir_.GetPath();
+    }
 
     quota_policy_ = new MockSpecialStoragePolicy;
     mock_quota_manager_ = new MockQuotaManager(
-        MemoryOnly() /* is incognito */, temp_dir_.path(),
-        base::ThreadTaskRunnerHandle::Get().get(),
+        is_incognito, temp_dir_path, base::ThreadTaskRunnerHandle::Get().get(),
         base::ThreadTaskRunnerHandle::Get().get(), quota_policy_.get());
     mock_quota_manager_->SetQuota(GURL(kOrigin), storage::kStorageTypeTemporary,
                                   1024 * 1024 * 100);
@@ -358,7 +361,7 @@ class CacheStorageCacheTest : public testing::Test {
     CreateRequests(blob_storage_context);
 
     cache_ = base::MakeUnique<TestCacheStorageCache>(
-        GURL(kOrigin), kCacheName, temp_dir_.path(), nullptr /* CacheStorage */,
+        GURL(kOrigin), kCacheName, temp_dir_path, nullptr /* CacheStorage */,
         BrowserContext::GetDefaultStoragePartition(&browser_context_)
             ->GetURLRequestContext(),
         quota_manager_proxy_, blob_storage_context->context()->AsWeakPtr());