Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2316033002: [turbofan] Remove a DCHECK from the register allocator. (Closed)

Created:
4 years, 3 months ago by epertoso
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Mircea Trofin, bbudge
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove a DCHECK from the register allocator. The assumption that held when this DCHECK was introduced are no longer valid. Furthermore, the code below it seems to merge two non-overlapping intervals anyway. Committed: https://crrev.com/cab765fe501f4a39496b713274cf5ceba8f18897 Cr-Commit-Position: refs/heads/master@{#39238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
epertoso
4 years, 3 months ago (2016-09-07 09:55:04 UTC) #7
mvstanton
lgtm
4 years, 3 months ago (2016-09-07 09:56:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316033002/1
4 years, 3 months ago (2016-09-07 09:59:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 10:02:00 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 10:02:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cab765fe501f4a39496b713274cf5ceba8f18897
Cr-Commit-Position: refs/heads/master@{#39238}

Powered by Google App Engine
This is Rietveld 408576698