Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: pkg/barback/test/package_graph/lazy_transformer_test.dart

Issue 231603005: Preserve laziness in declaring transformers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/test/package_graph/lazy_transformer_test.dart
diff --git a/pkg/barback/test/package_graph/lazy_transformer_test.dart b/pkg/barback/test/package_graph/lazy_transformer_test.dart
index 2f08772bc14a1f517f6d0ca1929181a82014182d..0608090ffb50ae360697e042354a15aacb21c3a8 100644
--- a/pkg/barback/test/package_graph/lazy_transformer_test.dart
+++ b/pkg/barback/test/package_graph/lazy_transformer_test.dart
@@ -82,29 +82,59 @@ main() {
expect(transformer.numRuns, completion(equals(1)));
});
- // test("a lazy asset piped into a declaring transformer isn't eagerly "
- // "compiled", () {
- // var transformer1 = new LazyRewriteTransformer("blub", "blab");
- // var transformer2 = new DeclaringRewriteTransformer("blab", "blib");
- // initGraph(["app|foo.blub"], {"app": [
- // [transformer1], [transformer2]
- // ]});
- // updateSources(["app|foo.blub"]);
- // buildShouldSucceed();
- // expect(transformer1.numRuns, completion(equals(0)));
- // expect(transformer2.numRuns, completion(equals(0)));
- // });
- //
- // test("a lazy asset piped into a declaring transformer is compiled "
- // "on-demand", () {
- // initGraph(["app|foo.blub"], {"app": [
- // [new LazyRewriteTransformer("blub", "blab")],
- // [new DeclaringRewriteTransformer("blab", "blib")]
- // ]});
- // updateSources(["app|foo.blub"]);
- // expectAsset("app|foo.blib", "foo.blab.blib");
- // buildShouldSucceed();
- // });
+ test("a lazy asset piped into a declaring transformer isn't eagerly "
+ "compiled", () {
+ var transformer1 = new LazyRewriteTransformer("blub", "blab");
+ var transformer2 = new DeclaringRewriteTransformer("blab", "blib");
+ initGraph(["app|foo.blub"], {"app": [
+ [transformer1], [transformer2]
+ ]});
+ updateSources(["app|foo.blub"]);
+ buildShouldSucceed();
+ expect(transformer1.numRuns, completion(equals(0)));
+ expect(transformer2.numRuns, completion(equals(0)));
+ });
+
+ test("a lazy asset piped into a declaring transformer is compiled "
+ "on-demand", () {
+ initGraph(["app|foo.blub"], {"app": [
+ [new LazyRewriteTransformer("blub", "blab")],
+ [new DeclaringRewriteTransformer("blab", "blib")]
+ ]});
+ updateSources(["app|foo.blub"]);
+ expectAsset("app|foo.blib", "foo.blab.blib");
+ buildShouldSucceed();
+ });
+
+ test("a lazy asset piped through many declaring transformers isn't eagerly "
+ "compiled", () {
+ var transformer1 = new LazyRewriteTransformer("one", "two");
+ var transformer2 = new DeclaringRewriteTransformer("two", "three");
+ var transformer3 = new DeclaringRewriteTransformer("three", "four");
+ var transformer4 = new DeclaringRewriteTransformer("four", "five");
+ initGraph(["app|foo.one"], {"app": [
+ [transformer1], [transformer2], [transformer3], [transformer4]
+ ]});
+ updateSources(["app|foo.one"]);
+ buildShouldSucceed();
+ expect(transformer1.numRuns, completion(equals(0)));
+ expect(transformer2.numRuns, completion(equals(0)));
+ expect(transformer3.numRuns, completion(equals(0)));
+ expect(transformer4.numRuns, completion(equals(0)));
+ });
+
+ test("a lazy asset piped through many declaring transformers is compiled "
+ "on-demand", () {
+ initGraph(["app|foo.one"], {"app": [
+ [new LazyRewriteTransformer("one", "two")],
+ [new DeclaringRewriteTransformer("two", "three")],
+ [new DeclaringRewriteTransformer("three", "four")],
+ [new DeclaringRewriteTransformer("four", "five")]
+ ]});
+ updateSources(["app|foo.one"]);
+ expectAsset("app|foo.five", "foo.two.three.four.five");
+ buildShouldSucceed();
+ });
Bob Nystrom 2014/04/10 20:45:34 Very cool.
test("a lazy asset works as a cross-package input", () {
initGraph({
« pkg/barback/lib/src/transform_node.dart ('K') | « pkg/barback/lib/src/transform_node.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698