Allow empty keys in hmac_openssl.cc.

crypto/hmac_unittest.cc

Index: crypto/hmac_unittest.cc
diff --git a/crypto/hmac_unittest.cc b/crypto/hmac_unittest.cc
index f0844a9186c9d661273483266408dcb9b2e1a3c1..6bcd1bc2e3a4dda86406c0b6d3620d587126428c 100644
--- a/crypto/hmac_unittest.cc
+++ b/crypto/hmac_unittest.cc
@@ -275,3 +275,21 @@ TEST(HMACTest, Verify) {
         base::StringPiece(empty_digest, kSHA1DigestSize)));
   }
 }
+
+TEST(HMACTest, EmptyKey) {
+  // Test vector from https://en.wikipedia.org/wiki/HMAC
+  const char* kExpectedDigest =
+      "\xFB\xDB\x1D\x1B\x18\xAA\x6C\x08\x32\x4B\x7D\x64\xB7\x1F\xB7\x63"
+      "\x70\x69\x0E\x1D";
+  base::StringPiece data("", 0u);

[wtc, 2014/04/10 18:43:41]

You can also try using a std::string:

  std::string data;

My experiments show that data.data() is a non-null pointer on Linux and Windows.
Your current solution is fine, too.

[davidben, 2014/04/10 18:54:29]

Yeah, per C++11, std::string::data and std::string::c_str are the same and both
include the trailing NUL. I think it's actually not required to in C++03, but
putting the NUL byte in when calling c_str would be insane so I doubt anyone
does that. Though std::string::data apparently always returns non-NULL per C++03
too:

"If size() is zero, the member returns a non-null pointer that is copyable and
can have zero added to it"

which does make me wonder what that pointer is supposed to point to... something
random?


Anyway... empty byte arrays. They are ridiculous. :-)

+
+  crypto::HMAC hmac(crypto::HMAC::SHA1);
+  ASSERT_TRUE(hmac.Init(NULL, 0));
+
+  unsigned char digest[kSHA1DigestSize];
+  EXPECT_TRUE(hmac.Sign(data, digest, kSHA1DigestSize));
+  EXPECT_EQ(0, memcmp(kExpectedDigest, digest, kSHA1DigestSize));
+
+  EXPECT_TRUE(hmac.Verify(
+      data, base::StringPiece(kExpectedDigest, kSHA1DigestSize)));
+}