Notify the renderer if a history navigation has no subframe items.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 3624 matching lines @@
     EXPECT_EQ(main_url_a, new_entry->root_node()->frame_entry->url());
     ASSERT_EQ(1U, new_entry->root_node()->children.size());
     EXPECT_EQ(frame_url_b,
               new_entry->root_node()->children[0]->frame_entry->url());
   } else {
     // There are no subframe FrameNavigationEntries by default.
     EXPECT_EQ(0U, new_entry->root_node()->children.size());
   }
 }
 
+// Verify that we can finish loading a page on restore if the PageState is
+// missing subframes.  See https://crbug.com/638088.
+IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
+                       FrameNavigationEntry_RestoreViaPartialPageState) {
+  GURL main_url(embedded_test_server()->GetURL(
+      "a.com", "/navigation_controller/inject_into_blank_iframe.html"));
+  GURL blank_url(url::kAboutBlankURL);
+  const NavigationControllerImpl& controller =
+      static_cast<const NavigationControllerImpl&>(
+          shell()->web_contents()->GetController());
+
+  // Create a NavigationEntry to restore, as if it had been loaded before.  The
+  // page has an about:blank iframe and injects content into it, but the
+  // PageState lacks any subframe history items.  This may happen during a
+  // restore of a bad session or if the page has changed since the last visit.
+  // Chrome should be robust to this and should be able to load the frame from
+  // its default URL.
+  std::unique_ptr<NavigationEntryImpl> restored_entry =
+      NavigationEntryImpl::FromNavigationEntry(
+          NavigationControllerImpl::CreateNavigationEntry(
+              main_url, Referrer(), ui::PAGE_TRANSITION_RELOAD, false,
+              std::string(), controller.GetBrowserContext()));
+  restored_entry->SetPageID(0);
+  restored_entry->SetPageState(PageState::CreateFromURL(main_url));
+  EXPECT_EQ(0U, restored_entry->root_node()->children.size());
+
+  // Restore the new entry in a new tab and verify the iframe loads and has
+  // content injected into it.
+  std::vector<std::unique_ptr<NavigationEntry>> entries;
+  entries.push_back(std::move(restored_entry));
+  Shell* new_shell = Shell::CreateNewWindow(
+      controller.GetBrowserContext(), GURL::EmptyGURL(), nullptr, gfx::Size());
+  FrameTreeNode* new_root =
+      static_cast<WebContentsImpl*>(new_shell->web_contents())
+          ->GetFrameTree()
+          ->root();
+  NavigationControllerImpl& new_controller =
+      static_cast<NavigationControllerImpl&>(
+          new_shell->web_contents()->GetController());
+  new_controller.Restore(entries.size() - 1,

[alexmos, 2016/09/22 01:44:06]

Is there a reason why the restore has to be in a new tab?  (wondering since
nothing's been loaded in the current tab yet.)

[Charlie Reis, 2016/09/22 21:00:37]

Good call.  Done.

+                         RestoreType::LAST_SESSION_EXITED_CLEANLY, &entries);
+  ASSERT_EQ(0u, entries.size());
+  {
+    TestNavigationObserver restore_observer(new_shell->web_contents());
+    new_controller.LoadIfNecessary();
+    restore_observer.Wait();
+  }
+  ASSERT_EQ(1U, new_root->child_count());
+  EXPECT_EQ(main_url, new_root->current_url());
+  EXPECT_EQ(blank_url, new_root->child_at(0)->current_url());
+
+  EXPECT_EQ(1, new_controller.GetEntryCount());
+  EXPECT_EQ(0, new_controller.GetLastCommittedEntryIndex());
+  NavigationEntryImpl* new_entry = new_controller.GetLastCommittedEntry();
+
+  // Verify subframe entries if they're enabled (e.g. in --site-per-process).

[alexmos, 2016/09/22 01:44:06]

Since they're enabled everywhere now, how long until we can start
unconditionally checking the FrameNavigationEntries in tests? :)

[Charlie Reis, 2016/09/22 21:00:37]

We plan to rip out the old path in M56.  That makes changes easier to test and
merge if we discover any showstoppers.

(And yes, I can't wait!)  :)

+  if (SiteIsolationPolicy::UseSubframeNavigationEntries()) {
+    // The entry should have a FrameNavigationEntry for the blank subframe.
+    EXPECT_EQ(main_url, new_entry->root_node()->frame_entry->url());
+    ASSERT_EQ(1U, new_entry->root_node()->children.size());
+    EXPECT_EQ(blank_url,
+              new_entry->root_node()->children[0]->frame_entry->url());
+  } else {
+    EXPECT_EQ(0U, new_entry->root_node()->children.size());
+  }
+
+  // Verify that the parent was able to script the iframe.
+  std::string expected_text("Injected text");
+  {
+    std::string value;
+    EXPECT_TRUE(ExecuteScriptAndExtractString(
+        new_root->child_at(0),
+        "domAutomationController.send(document.body.innerHTML)", &value));
+    EXPECT_EQ(expected_text, value);
+  }
+}
+
 // Verifies that the |frame_unique_name| is set to the correct frame, so that we
 // can match subframe FrameNavigationEntries to newly created frames after
 // back/forward and restore.
 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
                        FrameNavigationEntry_FrameUniqueName) {
   const NavigationControllerImpl& controller =
       static_cast<const NavigationControllerImpl&>(
           shell()->web_contents()->GetController());
 
   // 1. Navigate the main frame.
@@ skipping 2387 matching lines @@
   content::FaviconStatus& favicon_status2 = entry->GetFavicon();
   EXPECT_TRUE(favicon_status2.valid);
 
   ASSERT_TRUE(RendererLocationReplace(shell(), GURL("data:text/html,page2")));
   entry = controller.GetLastCommittedEntry();
   content::FaviconStatus& favicon_status3 = entry->GetFavicon();
   EXPECT_FALSE(favicon_status3.valid);
 }
 
 }  // namespace content