Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2315993002: Revert of GN(Android): Stop specifying depfile under outputs (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
michaelbai, Dirk Pranke
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GN(Android): Stop specifying depfile under outputs (patchset #2 id:20001 of https://codereview.chromium.org/2305283002/ ) Reason for revert: Will update when fixed. Original issue's description: > GN(Android): Stop specifying depfile under outputs > > Doing so is unnecessary (GN already knows that depfiles are generated by > their target), and causes the unwanted side-effect of changes to .d > files triggering rebuilds of dependent targets. > > BUG=639042 > > Committed: https://crrev.com/fd47b4e4232b99dfb4044b79eea66a7e6b2c2a64 > Cr-Commit-Position: refs/heads/master@{#416710} TBR=michaelbai@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -25 lines) Patch
M android_webview/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M build/config/android/internal_rules.gni View 17 chunks +18 lines, -5 lines 0 comments Download
M build/config/android/rules.gni View 14 chunks +14 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 6 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agrieve
Created Revert of GN(Android): Stop specifying depfile under outputs
4 years, 3 months ago (2016-09-07 02:25:59 UTC) #1
michaelbai
On 2016/09/07 02:25:59, agrieve wrote: > Created Revert of GN(Android): Stop specifying depfile under outputs ...
4 years, 2 months ago (2016-10-13 03:36:14 UTC) #2
agrieve
4 years, 2 months ago (2016-10-13 13:35:31 UTC) #3
Message was sent while issue was closed.
On 2016/10/13 03:36:14, michaelbai wrote:
> On 2016/09/07 02:25:59, agrieve wrote:
> > Created Revert of GN(Android): Stop specifying depfile under outputs
> 
> shall this be closed?

closed.

Powered by Google App Engine
This is Rietveld 408576698