Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2315923003: [Android] Add gtest implementation documentation. (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add gtest implementation documentation. BUG= Committed: https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd Cr-Commit-Position: refs/heads/master@{#417149}

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 2

Patch Set 3 : mikecase comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -27 lines) Patch
A + testing/android/docs/README.md View 1 1 chunk +1 line, -2 lines 0 comments Download
A testing/android/docs/gtest_implementation.md View 1 2 1 chunk +132 lines, -0 lines 0 comments Download
D testing/android/docs/index.md View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 3 months ago (2016-09-07 04:33:07 UTC) #2
mikecase (-- gone --)
lgtm! Awesome doc :D 1 question, and its mostly for my benefit. https://codereview.chromium.org/2315923003/diff/20001/testing/android/docs/gtest_implementation.md File testing/android/docs/gtest_implementation.md ...
4 years, 3 months ago (2016-09-07 18:55:23 UTC) #3
jbudorick
https://codereview.chromium.org/2315923003/diff/20001/testing/android/docs/gtest_implementation.md File testing/android/docs/gtest_implementation.md (right): https://codereview.chromium.org/2315923003/diff/20001/testing/android/docs/gtest_implementation.md#newcode124 testing/android/docs/gtest_implementation.md:124: The test runner simply executes the binary directly and ...
4 years, 3 months ago (2016-09-08 00:32:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315923003/40001
4 years, 3 months ago (2016-09-08 00:33:28 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 01:30:47 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:36:09 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd
Cr-Commit-Position: refs/heads/master@{#417149}

Powered by Google App Engine
This is Rietveld 408576698