chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h - Issue 2315903002: arc: Fix crash in multi-user env on task stop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h

Issue 2315903002: arc: Fix crash in multi-user env on task stop. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc » ('j') | chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h

diff --git a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h

index a233b99c48341f94541e5576842d663fdc38039d..3e0434c02890d4e0639ebed5c790847ea5e43fd2 100644

--- a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h

+++ b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h

@@ -99,7 +99,8 @@ class ArcAppWindowLauncherController : public AppWindowLauncherController,

AppWindow* GetAppWindowForTask(int task_id);

- void MayAttachContollerToWindow(aura::Window* window);

+ void MaybeAttachContollerToWindow(aura::Window* window);

Mr4D (OOO till 08-26) 2016/09/07 20:17:34 Why rename "May" -> "Maybe"? That sounds really od

khmel 2016/09/07 21:01:47 Based on my previous reviews :) There is a style t

+ void MaybeAttachContollerToWindows();

void SetOrientationLockForAppWindow(AppWindow* app_window);