Changes the Omnibox input type to SEARCH.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 32 matching lines @@
 #include "ui/gfx/selection_model.h"
 #include "ui/views/border.h"
 #include "ui/views/button_drag_utils.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/ime/input_method.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/widget.h"
 #include "url/gurl.h"
 
+#if defined(OS_WIN)
+#include "base/win/metro.h"
+#include "chrome/browser/browser_process.h"
+#endif
+
 #if defined(USE_AURA)
 #include "ui/aura/focus_manager.h"
 #include "ui/aura/root_window.h"
 #include "ui/compositor/layer.h"
 #endif
 
 namespace {
 
 // Stores omnibox state for each tab.
 struct OmniboxState : public base::SupportsUserData::Data {
@@ skipping 18 matching lines @@
 
 OmniboxState::~OmniboxState() {}
 
 // This will write |url| and |text| to the clipboard as a well-formed URL.
 void DoCopyURL(const GURL& url, const string16& text) {
   BookmarkNodeData data;
   data.ReadFromTuple(url, text);
   data.WriteToClipboard();
 }
 
+// The IME's input mode automatically falls into the Latin character mode if
+// ui::TEXT_INPUT_TYPE_URL is specified on Windows TSF environment, and that is
+// bad experience for IME users.  However, software keyboards provide special
+// layout when ui::TEXT_INPUT_TYPE_URL is specified, for example ".com" and "/"
+// keys appear on English software keyboard.  So we set
+// ui::TEXT_INPUT_TYPE_SEARCH for those who are likely IME users, and
+// ui::TEXT_INPUT_TYPE_URL for the rest who are likely non-IME users.

[Peter Kasting, 2013/09/13 17:16:37]

Nit: This comment is pretty good, here's my attempt at fixing some grammar
issues and clarifying:

We'd like to set the text input type to TEXT_INPUT_TYPE_URL, because this
triggers URL-specific layout in software keyboards, e.g. adding top-level "/"
and ".com" keys for English.  However, this also causes IMEs to default to Latin
character mode, which makes entering search queries difficult for IME users. 
Therefore, we try to guess whether an IME will be used based on the application
language, and set the input type accordingly.

[Yuki, 2013/09/17 08:33:39]

Done.

+ui::TextInputType DetermineTextInputType() {
+#if defined(OS_WIN)
+  if (base::win::IsTSFAwareRequired()) {
+    DCHECK(g_browser_process);
+    const std::string& locale = g_browser_process->GetApplicationLocale();
+    const std::string& language = locale.substr(0, 2);
+    // Suppose CJK + Thai users are using an IME.

[Peter Kasting, 2013/09/13 17:16:37]

Nit: Suppose -> Assume

[Yuki, 2013/09/17 08:33:39]

Done.

+    if (language == "ja" ||
+        language == "ko" ||
+        language == "th" ||
+        language == "zh")
+      return ui::TEXT_INPUT_TYPE_SEARCH;
+  }
+#endif
+  return ui::TEXT_INPUT_TYPE_URL;
+}
+
 bool IsOmniboxAutoCompletionForImeEnabled() {
   return !CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kDisableOmniboxAutoCompletionForIme);
 }
 
 }  // namespace
 
 // static
 const char OmniboxViewViews::kViewClassName[] = "OmniboxViewViews";
 
@@ skipping 29 matching lines @@
   // Explicitly teardown members which have a reference to us.  Just to be safe
   // we want them to be destroyed before destroying any other internal state.
   popup_view_.reset();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // OmniboxViewViews public:
 
 void OmniboxViewViews::Init() {
   SetController(this);
-  SetTextInputType(ui::TEXT_INPUT_TYPE_URL);
+  SetTextInputType(DetermineTextInputType());
   SetBackgroundColor(location_bar_view_->GetColor(
       ToolbarModel::NONE, LocationBarView::BACKGROUND));
 
   if (popup_window_mode_)
     SetReadOnly(true);
 
   // Initialize the popup view using the same font.
   popup_view_.reset(OmniboxPopupContentsView::Create(
       font_list(), this, model(), location_bar_view_));
 
@@ skipping 746 matching lines @@
   const string16 text(GetClipboardText());
   if (!text.empty()) {
     // Record this paste, so we can do different behavior.
     model()->on_paste();
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted.
     text_before_change_.clear();
     InsertOrReplaceText(text);
   }
 }