Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2315893002:
Simplify SkColorSpace DstGamma UMA (Closed)
|
Created:
4 years, 3 months ago by msarett Modified:
4 years, 3 months ago CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSimplify SkColorSpace DstGamma UMA
We've learned what we wanted to learn, now it's time to
simplify this measurement so we can sanitize the Skia API.
BUG=
Committed: https://crrev.com/b5844e22c8a595a662a3e5d4b0878e8ef9c8da36
Cr-Commit-Position: refs/heads/master@{#416740}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Fix #
Dependent Patchsets: Messages
Total messages: 26 (18 generated)
Description was changed from ========== Simplify SkColorSpace DstGamma enum We've learned what we wanted to learn, now it's time to simplify this measurement so we can sanitize the Skia API. BUG= ========== to ========== Simplify SkColorSpace DstGamma UMA We've learned what we wanted to learn, now it's time to simplify this measurement so we can sanitize the Skia API. BUG= ==========
Patchset #1 (id:1) has been deleted
msarett@google.com changed reviewers: + fmalita@chromium.org, mtklein@google.com
mtklein@chromium.org changed reviewers: + mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org, fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/2315893002/#ps60001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Simplify SkColorSpace DstGamma UMA We've learned what we wanted to learn, now it's time to simplify this measurement so we can sanitize the Skia API. BUG= ========== to ========== Simplify SkColorSpace DstGamma UMA We've learned what we wanted to learn, now it's time to simplify this measurement so we can sanitize the Skia API. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Simplify SkColorSpace DstGamma UMA We've learned what we wanted to learn, now it's time to simplify this measurement so we can sanitize the Skia API. BUG= ========== to ========== Simplify SkColorSpace DstGamma UMA We've learned what we wanted to learn, now it's time to simplify this measurement so we can sanitize the Skia API. BUG= Committed: https://crrev.com/b5844e22c8a595a662a3e5d4b0878e8ef9c8da36 Cr-Commit-Position: refs/heads/master@{#416740} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b5844e22c8a595a662a3e5d4b0878e8ef9c8da36 Cr-Commit-Position: refs/heads/master@{#416740} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
