Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2315873002: Remove calls to deprecated MessageLoop methods in net. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, agl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in net. This CL (hopefully) removes all calls to these methods in net: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=agl@chromium.org Committed: https://crrev.com/81f6ee03502186923da48690101f66441ffe14d6 Cr-Commit-Position: refs/heads/master@{#418861}

Patch Set 1 #

Patch Set 2 : fix test error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M net/android/network_change_notifier_android_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/dns/dns_config_service_posix_unittest.cc View 1 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-07 15:21:18 UTC) #9
fdoray
ping
4 years, 3 months ago (2016-09-09 14:20:25 UTC) #10
fdoray
gavinp@: PTAL
4 years, 3 months ago (2016-09-12 12:22:33 UTC) #12
gavinp
lgtm, whoops about the delay, ty
4 years, 3 months ago (2016-09-15 13:21:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315873002/20001
4 years, 3 months ago (2016-09-15 13:34:07 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 14:10:57 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:13:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81f6ee03502186923da48690101f66441ffe14d6
Cr-Commit-Position: refs/heads/master@{#418861}

Powered by Google App Engine
This is Rietveld 408576698