Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2315863003: Revert of More robust check for sRGB gamma tables (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
Brian Osman, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of More robust check for sRGB gamma tables (patchset #2 id:60001 of https://codereview.chromium.org/2263233003/ ) Reason for revert: From the previous commit message: "This check is not fast. If we find that it doesn't help us recognize sRGB curves, we should delete it." Turns out it doesn't help. Looks to me like the tables are not sRGB. Original issue's description: > More robust check for sRGB gamma tables > > This is in response to a UMA showing that 5% dst gammas are > unidentified tables. We want to see if some of these tables > should be marked as sRGB. > https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial > > This check is not fast. If we find that it doesn't help > us recognize sRGB curves, we should delete it. > > BUG=skia:5656 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263233003 > > Committed: https://skia.googlesource.com/skia/+/4ff08df15a8042cdb4fc90a82e1044847d0de300 TBR=mtklein@google.com,brianosman@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5656 Committed: https://skia.googlesource.com/skia/+/e54f4b7cf395665bbe1d6ee397d50f4c0fc4fd04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -37 lines) Patch
M src/core/SkColorSpace_ICC.cpp View 2 chunks +3 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of More robust check for sRGB gamma tables
4 years, 3 months ago (2016-09-06 20:25:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315863003/1
4 years, 3 months ago (2016-09-06 20:25:31 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 21:41:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e54f4b7cf395665bbe1d6ee397d50f4c0fc4fd04

Powered by Google App Engine
This is Rietveld 408576698